testing - How to test for leaking connections in a Go test? -


after i've found leaks in program, i've solved problem. however, now i'm trying find out how " test " leaking connections in go test? question.

i've tried change number of requests in test, didn't matter. no matter do, current number of tcp connections in test stay same.

func testleakingconnections(t *testing.t) {     getter := myhttp.new()      s := newserver(ok)     defer s.close()      cur := tcps(t)     := 0; < 1000; i++ {         r, _ := getter.getwithtimeout(s.url, time.millisecond*10)         r.body.close()     }      tries := 10; tries >= 0; tries-- {         growth := tcps(t) - cur         if growth > 5 {             t.error("leaked")             return         }     } }  // find tcp connections func tcps(t *testing.t) (conns int) {     lsof, err := exec.command("lsof", "-n", "-p", strconv.itoa(os.getpid())).output()     if err != nil {         t.skip("skipping test; error finding or running lsof")     }      _, ls := range strings.split(string(lsof), "\n") {         if strings.contains(ls, "tcp") {             conns++         }     }     return }  func newserver(f http.handlerfunc) *httptest.server {     return httptest.newserver(http.handlerfunc(f)) }  func ok(w http.responsewriter, r *http.request) {     w.header().add("content-type", "application/xml")     io.writestring(w, "<xml></xml>") }  // myhttp package  // ...other code omitted clarification  func (g *getter) getwithtimeout(     url string,     timeout time.duration, ) (     *http.response, error, ) {     // leaking part     // moving out of here stop leaks     transport := http.transport{         dialcontext: (&net.dialer{             timeout: timeout,         }).dialcontext,         tlshandshaketimeout:   timeout,         responseheadertimeout: timeout,         expectcontinuetimeout: timeout,     }      client := http.client{         timeout:   timeout,         transport: &transport,     }      return client.get(url) }  // fixture worker package  // outside code injects getter fixture_worker this: getter := myhttp.new()  // newwithtimeout creates new fetcher timeout threshold func newwithtimeout(     getter myhttp.httpgetter,     fetchurl string,     timeout time.duration, ) *fetcher {     return &fetcher{getter, fetchurl, timeout} }  // fetch fetches fixture xml func (f *fetcher) fetch() (*parser.fixturexml, error) {     res, err := f.getter.getwithtimeout(f.fetchurl, f.timeout)     if err != nil {         if res != nil && res.body != nil {             res.body.close()         }         return nil, errors.wrap(err, errfetch.error())     }     defer res.body.close()      ioutil.readall(res.body)      return &parser.fixturexml{}, nil }

leaking conns gif

output of fixture worker lsof: https://pastebin.com/fdukpyse

output of test: https://pastebin.com/ugpk0czn

test never leaks whereas fixture worker leaks.

fixture worker using same code test, request http gets using myhttp package.

if want test represent reality, need use in same manner outside of tests. in case you're not reading of responses, , transport happens preventing lost connections because it's discarding them possible since can't reused.

reading response use connection, , state it's "leaked". need handle errors in cases, , need close() response body. pattern handle http response , make sure it's closed simple, , doesn't require testing (see what happen if don't close response.body in golang?)

    resp, err := getwithtimeout(s.url)     if err != nil {         t.fatal(err)     }     ioutil.readall(resp.body)     resp.body.close()

this arguably of limited usefulness, since common bugs result improper error , response handling, , you're not testing because test needs correctly in first place.

the remaining problem here getwithtimeout method returns error value and valid http response, contradicts http package documentation user's expectations. if you're going insert error, better handle response @ same point ensure body closed , discarded.

finally, of getwithtimeout superfluous, since not creating transports every time incorrect, creating http.client every request unnecessary meant reused , safe concurrent use.


Comments

Post a Comment

Popular posts from this blog

Is there a better way to structure post methods in Class Based Views -

i'm using class based views in django , never specify url in ajax calls , omit action parameter in form because know these requests go through post method of class based view. notice view - profile page make many requests depending on user updating on page - post method become convoluted , if/else mess example: def post(self, request, *args, **kwargs): # handle user changing available date if request.post.get('availabledate') != none: self.updateavailabledate(request) return jsonresponse({'result':'success'}) if request.post.get('newprojectname') != none: creative_user = creativeuserprofile.objects.get(id = request.user.id) project = project.create_project(creative_user, request.post['newprojectname']) project.save() return jsonresponse({'projectid': project.id }) if request.post.get('projectimage') != none , request.files['file']: proj...
Read more

performance - Why is XCHG reg, reg a 3 micro-op instruction on modern Intel architectures? -

i'm doing micro-optimization on performance critical part of code , came across sequence of instructions (in at&t syntax): add %rax, %rbx mov %rdx, %rax mov %rbx, %rdx i thought had use case xchg allow me shave instruction , write: add %rbx, %rax xchg %rax, %rdx however, dimay found agner fog's instruction tables , xchg 3 micro-op instruction 2 cycle latency on sandy bridge, ivy bridge, broadwell, haswell , skylake. 3 whole micro-ops , 2 cycles of latency! 3 micro-ops throws off 4-1-1-1 cadence , 2 cycle latency makes worse original in best case since last 2 instructions in original might execute in parallel. now... cpu might breaking instruction micro-ops equivalent to: mov %rax, %tmp mov %rdx, %rax mov %tmp, %rdx where tmp anonymous internal register , suppose last 2 micro-ops run in parallel latency 2 cycles. given register renaming occurs on these micro-architectures, though, doesn't make sense me done way. why wouldn't register renamer ...
Read more

c# - Asp.net web api : redirect unauthorized requst to forbidden page -

im trying redirect unauthorized request forbidden page instead i'm getting forbidden page in response body , how can fix ? here's startup class : app.createperowincontext(storecontext.create); app.createperowincontext<applicationusermanager>(applicationusermanager.create); app.createperowincontext<applicationsigninmanager>(applicationsigninmanager.create); app.usecookieauthentication(new cookieauthenticationoptions { authenticationtype = defaultauthenticationtypes.applicationcookie, expiretimespan = timespan.fromdays(30), }); app.useexternalsignincookie(defaultauthenticationtypes.externalcookie); app.usetwofactorsignincookie(defaultauthenticationtypes.twofactorcookie, timespan.fromminutes(5)); app.usetwofactorrememberbrowsercookie(defaultauthenticationtypes.twofactorrememberbrowsercookie); the method im trying reach : [httpget] [authorize(roles = "admin")] public string getcurrentusername() { return userman...
Read more