performance - Is it worth calling php fclose twice? -
i have script set run once per hour.
$refresh_token_file = fopen("refresh_token", "r+") or die("unable open refresh_token file!"); $refresh_token = fgets($refresh_token_file); fclose($refresh_token_file); $url = 'https://api.coolwebsite.com'; $fields = array( 'client_id' => '007', 'refresh_token' => $refresh_token ); $curl = curl_init($service_url); curl_setopt($curl, curlopt_returntransfer, true); curl_setopt($curl, curlopt_post, count($fields)); curl_setopt($curl, curlopt_postfields, $fields); $curl_response = curl_exec($curl); curl_close($curl); $json = json_decode($curl_response, true); if(isset($json['access_token']) && isset($json['refresh_token'])){ $access_token = $json['access_token']; $refresh_token = $json['refresh_token']; $access_token_file = fopen("access_token", "w") or die("unable open access_token file!"); $refresh_token_file = fopen("refresh_token", "w") or die("unable open refresh_token file!"); fwrite($access_token_file, $access_token); fwrite($refresh_token_file, $refresh_token); fclose($access_token_file); fclose($refresh_token_file); }else{ die("error @ json"); } as see, open , close same file (refresh_token) twice. worth effort make close once?
this may overthinking; got pomodoro time spare. attention.
opening , closing files expensive operation they require server allocate resources , set of buffers. better keep open file open further work required on it. means open once, complete operations , close it.
Comments
Post a Comment