Caesar Cypher in C giving incorrect output -


trying create caesar cypher in c , getting troublesome output lowercase letters exceed 'z' when shifting letters

#include <stdio.h>  void confab(const char* intext, int shift, char* outtext)  {     int = 0;     int j = 0;     char character = '\0';     while (intext[i] != '\0') {         if (intext[i] >= 'a' && intext[i] <= 'z') {             character = intext[i] + shift;             if (character > 'z') {                 character = character - 'z' + 'a' - 1;             }             outtext[j] = character;             j += 1;         } else if (intext[i] >= 'a' && intext[i] <= 'z') {             character = intext[i] + shift;             if (character > 'z') {                 character = (character - 'z' + 'a' - 1);             }             outtext[j] = character;             j += 1;         } else {             outtext[j] = intext[i];             j += 1;         }         += 1;     } }   int main(void) {     char buffer[60] = {0};     char* s = "the quick brown fox jumps on lazy dog.";     confab(s, 13, buffer);     printf("%s\n", buffer); }

is giving output: 

gur d\202vpx oeb\204a sb\205 w\202zc\200 b\203re \201ur yn\207\206 qbt.

instead of:

gur dhvpx oebja sbk whzcf bire gur ynml qbt.

suspecting ascii arithmetic off in if statement lowercase letters.

the problem code character variable declared signed 1-byte number.

so looking @ ascii table, a-z in range of 97-122. problem when you're trying shift more 5, overflow because signed 1-byte number can't exceed 127.

so changing char character = '\0'; unsigned char character = '\0'; job.

you can refer here maximum number of integer byte - https://en.wikipedia.org/wiki/integer_(computer_science)#common_integral_data_types


Comments

Post a Comment

Popular posts from this blog

Is there a better way to structure post methods in Class Based Views -

i'm using class based views in django , never specify url in ajax calls , omit action parameter in form because know these requests go through post method of class based view. notice view - profile page make many requests depending on user updating on page - post method become convoluted , if/else mess example: def post(self, request, *args, **kwargs): # handle user changing available date if request.post.get('availabledate') != none: self.updateavailabledate(request) return jsonresponse({'result':'success'}) if request.post.get('newprojectname') != none: creative_user = creativeuserprofile.objects.get(id = request.user.id) project = project.create_project(creative_user, request.post['newprojectname']) project.save() return jsonresponse({'projectid': project.id }) if request.post.get('projectimage') != none , request.files['file']: proj
Read more

performance - Why is XCHG reg, reg a 3 micro-op instruction on modern Intel architectures? -

i'm doing micro-optimization on performance critical part of code , came across sequence of instructions (in at&t syntax): add %rax, %rbx mov %rdx, %rax mov %rbx, %rdx i thought had use case xchg allow me shave instruction , write: add %rbx, %rax xchg %rax, %rdx however, dimay found agner fog's instruction tables , xchg 3 micro-op instruction 2 cycle latency on sandy bridge, ivy bridge, broadwell, haswell , skylake. 3 whole micro-ops , 2 cycles of latency! 3 micro-ops throws off 4-1-1-1 cadence , 2 cycle latency makes worse original in best case since last 2 instructions in original might execute in parallel. now... cpu might breaking instruction micro-ops equivalent to: mov %rax, %tmp mov %rdx, %rax mov %tmp, %rdx where tmp anonymous internal register , suppose last 2 micro-ops run in parallel latency 2 cycles. given register renaming occurs on these micro-architectures, though, doesn't make sense me done way. why wouldn't register renamer
Read more

jquery - Responsive Navbar with Sub Navbar -

good day, forgive me nav vocabulary not best. if question confusing apologize. i'm working on navigation bar needs centered on page @ 768px , above. items in nav open (or perhaps toggle) subnav lives directly below. these nav should appear centered on page. i have been able work through responsive portion of nav bar, having main items align vertically , sub nav menu of each item roll out below, , gave them indent separation. working well. however, issue not responsive side, behavior @ width greater 768px. happens toggling menu's sub navigation pushes other main items down page below sub nav. here's code: $(document).ready(function () { //stick in fixed 100% height behind navbar don't wrap $('#slide-nav.navbar-inverse').after($('<div class="inverse" id="navbar-height-col"></div>')); $('#slide-nav.navbar-default').after($('<div id="navbar-height-col"></d
Read more