javascript - OnHistoryStateUpdated filter not working as expected -


i'm working on firefox add-on add pageaction when watching video in youtube. background script works until go youtube video other youtube page, pageaction doesn't disappear. code:

var filter = {   url:[     {       pathcontains: "watch",       hostsuffix: "youtube.com"     }   ] } function showpageaction(details) {   browser.pageaction.show(details.tabid); }  browser.webnavigation.oncommitted.addlistener(showpageaction, filter); browser.webnavigation.onhistorystateupdated.addlistener(showpageaction, filter);

it happens first time press other youtube link youtube video page (history, main, channel, etc), because when go youtube page first click, disappears. like:

  1. open new tab
  2. go directly www.youtube.com (doesn´t appear)
  3. press video (it appears, expected)
  4. press other link youtube page (main, history, cannel) (it's still there, shoudn't disappear?)
  5. press again other link different video (it disappears)

i thinking add filter in showpageaction function but, isn't filter of onhistorystateupdated supposed that?

the filter works expected; it's default resetting behavior doesn't.

the point of history state update based navigation no actual navigation happens (unlike oncommitted events). means ff doesn't hide automatically.

which means have take care of on navigations result in non-watch pages.

your best bet filter within listener:

// since history manipulation must preserve origin, //  can limit youtube domains performance const hostfilter = {   url: [{hostsuffix: "youtube.com"}] }  function updatepageaction(details) {   if (details.url.includes("watch")) {     browser.pageaction.show(details.tabid);   } else {     browser.pageaction.hide(details.tabid);   } }  browser.webnavigation.onhistorystateupdated.addlistener(   updatepageaction,   hostfilter );

Comments

Post a Comment

Popular posts from this blog

What is happening when Matlab is starting a "parallel pool"? -

running parallel cpu processes in matlab starts command parpool() according documentation , function: [creates] special job on pool of workers, , [connects] matlab client parallel pool. this function takes bit of time execute, on order of 30 seconds. in other multi-cpu paradigms openmp, parallel execution seems totally transparent -- i've never noticed behavior analogous matlab (granted i'm not experienced parallel programming). so, happening between time parpool() called , when finishes executing? takes long? parallel computing toolbox enables run matlab code in parallel using several different paradigms (e.g. jobs , tasks, parfor , spmd , parfeval , batch processing), , run either locally (parallelised across cores in local machine) or remotely (parallelised across machines in cluster - either 1 own, or 1 in cloud). in of these cases, code run on matlab workers , copies of matlab without interactive desktop. if you're intending run on remo...
Read more

angular - DownloadURL return null in below code -

when change file updated in firebase storage when try downloadurl show null. filechange(event: any) { const imagefolder: string = this.employee.id; const filelist: filelist = event.target.files; const file: file = filelist[0]; const storageref = firebase.storage().ref().child(`${imagefolder}/profile.jpg`).put(file); console.log(storageref.snapshot.downloadurl); } the put() asynchronous. if want url after file uploaded have this: firebase.storage().ref().child(`${imagefolder}/profile.jpg`).put(file).then((snapshot) => { storageref = snapshot.downloadurl: console.log(snapshot.downloadurl); });
Read more

php - Cannot override Laravel Spark authentication with own implementation -

during login process of laravel spark need request token of remote api. api stores exact same users , passwords laravel spark application. therefore need username , non hashed password of user during authentication process. i thought overriding authenticated method solution problem. in routes/web.php override post /login endpoint , pointing endpoint own logincontroller: <?php namespace app\http\controllers\auth; use illuminate\support\facades\log; use illuminate\http\request; use laravel\spark\http\controllers\auth\logincontroller sparklogincontroller; class logincontroller extends sparklogincontroller { /** * create new login controller instance. * * @return void */ public function __construct() { parent::__construct(); } /** * handle successful authentication attempt. * * @param request $request * @param \illuminate\contracts\auth\authenticatable $user * @return response */ public fu...
Read more