C: Getting wrong output which might have to do with null terminator? -


i writing program takes input of chars *intext, , shifts each alphabetical character amount shift create output of chars *outtext, (eg. in case of main function shown below, input "the quick brown fox jumps on lazy dog." should output gur dhvpx oebja sbk whzcf bire gur ynml qbt., shifting each letter 13.

the output however, aur ~\202vpx o\177|\204{ s|\205 w\202z}\200 |\203r\177 \201ur yn\207\206 q|t. don't know how null terminators work, think may have reason issue.

#include <stdio.h> #include <string.h> #include <ctype.h>  void confab(const char* intext, int shift, char* outtext) {     // visit each char of intext     // assign current val of intext current val of outtextheck     // if current val of intext letter, shift letter     // go next char of intext     outtext[0] = '\0';     while (*intext) {         *outtext = *intext;         if (isalpha(*intext)) {             *outtext = ((*outtext + shift) + '\0');         }         (intext++);         (outtext++);     }     outtext[strlen(outtext)] = '\0'; }  int main(void) {     char buffer[60] = {0};     char* s = "the quick brown fox jumps on lazy dog.";     confab(s, 13, buffer);     printf("%s\n", buffer); }

problem in format part.

you must take care of lowercase or uppercase first.

check if statement if character lowercase or uppercase.

if (isalpha(*intext)) {     if (isupper(*outtext)) {         *outtext = (((*outtext - 'a') + shift) % 26 + 'a');     } else {         *outtext = (((*outtext - 'a') + shift) % 26 + 'a');     } }

lowercase , uppercase values have different values in ascii table 1 after another, meaning letter b after a.

to result, have first subtract base character (either 'a' or 'a') mathematical job , after add again base character.

later, replace strlen null termination with

*outtext = 0;

full code

#include <stdio.h> #include <string.h> #include <ctype.h>  void confab(const char* intext, int shift, char* outtext) {     // visit each char of intext     // assign current val of intext current val of outtextheck     // if current val of intext letter, shift letter     // go next char of intext     outtext[0] = '\0';     while (*intext) {         *outtext = *intext;         if (isalpha(*intext)) {             char t = isupper(*outtext) ? 'a' : 'a';             int tmp = (((int)*outtext - t) + shift) % 26;             if (tmp < 0) {                 tmp += 26;             }             *outtext = tmp + t;         }         (intext++);         (outtext++);     }     *outtext = 0; }  int main(void) {     char buffer[60] = {0};     char* s = "the quick brown fox jumps on lazy dog.";     confab(s, -1, buffer);     printf("%s\n%s\n", s, buffer); }

Comments

Post a Comment

Popular posts from this blog

Is there a better way to structure post methods in Class Based Views -

i'm using class based views in django , never specify url in ajax calls , omit action parameter in form because know these requests go through post method of class based view. notice view - profile page make many requests depending on user updating on page - post method become convoluted , if/else mess example: def post(self, request, *args, **kwargs): # handle user changing available date if request.post.get('availabledate') != none: self.updateavailabledate(request) return jsonresponse({'result':'success'}) if request.post.get('newprojectname') != none: creative_user = creativeuserprofile.objects.get(id = request.user.id) project = project.create_project(creative_user, request.post['newprojectname']) project.save() return jsonresponse({'projectid': project.id }) if request.post.get('projectimage') != none , request.files['file']: proj...
Read more

performance - Why is XCHG reg, reg a 3 micro-op instruction on modern Intel architectures? -

i'm doing micro-optimization on performance critical part of code , came across sequence of instructions (in at&t syntax): add %rax, %rbx mov %rdx, %rax mov %rbx, %rdx i thought had use case xchg allow me shave instruction , write: add %rbx, %rax xchg %rax, %rdx however, dimay found agner fog's instruction tables , xchg 3 micro-op instruction 2 cycle latency on sandy bridge, ivy bridge, broadwell, haswell , skylake. 3 whole micro-ops , 2 cycles of latency! 3 micro-ops throws off 4-1-1-1 cadence , 2 cycle latency makes worse original in best case since last 2 instructions in original might execute in parallel. now... cpu might breaking instruction micro-ops equivalent to: mov %rax, %tmp mov %rdx, %rax mov %tmp, %rdx where tmp anonymous internal register , suppose last 2 micro-ops run in parallel latency 2 cycles. given register renaming occurs on these micro-architectures, though, doesn't make sense me done way. why wouldn't register renamer ...
Read more

c# - Asp.net web api : redirect unauthorized requst to forbidden page -

im trying redirect unauthorized request forbidden page instead i'm getting forbidden page in response body , how can fix ? here's startup class : app.createperowincontext(storecontext.create); app.createperowincontext<applicationusermanager>(applicationusermanager.create); app.createperowincontext<applicationsigninmanager>(applicationsigninmanager.create); app.usecookieauthentication(new cookieauthenticationoptions { authenticationtype = defaultauthenticationtypes.applicationcookie, expiretimespan = timespan.fromdays(30), }); app.useexternalsignincookie(defaultauthenticationtypes.externalcookie); app.usetwofactorsignincookie(defaultauthenticationtypes.twofactorcookie, timespan.fromminutes(5)); app.usetwofactorrememberbrowsercookie(defaultauthenticationtypes.twofactorrememberbrowsercookie); the method im trying reach : [httpget] [authorize(roles = "admin")] public string getcurrentusername() { return userman...
Read more