I am not getting desired output for a C program -


i doing c program sample input not giving sample output if use the. think program not calling function. guess have declared incorrectly. or logic wrong. getting 0 output. question given below.

write c function find kth occurrence of integer n in sequence of non-negative integers, , call function main.

your function should according following declaration:

int find(int n, int k);

input

you given input in 2 lines:

the first line contains non-negative integer, n, , positive integer k, in order. have find kth occurrence of n in sequence below.

the second line consists of sequence of non-negative integers, terminated -1. -1 not part of sequence.

output

if n occurs k times in sequence, output index of kth occurrence of n in sequence.

if n not occur k times in sequence, output -1.

(for example, second occurrence of integer 3 in sequence 1 1 3 2 3 -1 @ position 4 in sequence. first index in sequence 0.)

input:

3 2 1 1 2 3 3 -1

output:

4

code:

#include<stdio.h>  int check(int a,int n ,int k ){   int f;    int value;    int counter=0;     counter++;    if (a==n)   {     f++;   }   if(f==k)   {     value= counter;   }  return value; }  int main(void) {   int n , k,a;    int tempo;    scanf("%d",&n);   scanf("%d",&k);   while(a!=-1)   {     scanf("%d",&a);      tempo=check(a,n,k);    }   printf("%d",tempo);          return 0;          }

your check function has numerous problems:

int check(int a,int n ,int k ){

your prototype not match 1 in assignment - you're supposed take 2 arguments, neither of sequence of values you're checking against. somehow, someway, supposed access sequence within body of function, either referencing global array (bad), or reading input sequence within body of function (slightly less bad, , intent of exercise1). 

  int f;               int value;

auto variables not implicitly initialized in declaration - initial value indeterminate (it may 0, may trap representation, may valid non-zero integer value). cause problems later.

   int counter=0;     counter++;

i think know you're trying go here, , won't work written2 - counter exists lifetime of function. each time call check, new instance of counter created , initialized 0. won't remember value stored in previous call. 

  if (a==n)   {     f++;

f isn't guaranteed 0 @ point (or other specific value). could 0, or non-zero value, or trap representation (a bit pattern not correspond valid integer value). 

  }   if(f==k)   {     value= counter;   }  return value; }

at point, counter ever going 1 - initialize 0 @ function entry , increment it, never touch again. value ever going indeterminate or 1.

so, how should proceed here and satisfy requirements of assignment?

the less bad option read sequence within check (or find) function, although that's still pretty bad (again, i/o should separate operation, , we're assuming input comes through stdin). 

int find( int n, int k ) {   int next; // next value in sequence   ... // additional items index, number of matches, etc.    while ( scanf( "%d", &next ) == 1 && next != -1 )   {      // update index, next match n, k'th match, etc.   }   ... }

scanf poor tool interactive input, @ point simpler approach.

  1. which, honestly, isn't better keeping global array. i/o should factored out computation whenever possible, , if function *is* required read input stream, stream should specified parameter function - shouldn't force code assume input comes through stdin.
  2. counter need declared static retain value call call.


Comments

Post a Comment

Popular posts from this blog

Is there a better way to structure post methods in Class Based Views -

i'm using class based views in django , never specify url in ajax calls , omit action parameter in form because know these requests go through post method of class based view. notice view - profile page make many requests depending on user updating on page - post method become convoluted , if/else mess example: def post(self, request, *args, **kwargs): # handle user changing available date if request.post.get('availabledate') != none: self.updateavailabledate(request) return jsonresponse({'result':'success'}) if request.post.get('newprojectname') != none: creative_user = creativeuserprofile.objects.get(id = request.user.id) project = project.create_project(creative_user, request.post['newprojectname']) project.save() return jsonresponse({'projectid': project.id }) if request.post.get('projectimage') != none , request.files['file']: proj
Read more

performance - Why is XCHG reg, reg a 3 micro-op instruction on modern Intel architectures? -

i'm doing micro-optimization on performance critical part of code , came across sequence of instructions (in at&t syntax): add %rax, %rbx mov %rdx, %rax mov %rbx, %rdx i thought had use case xchg allow me shave instruction , write: add %rbx, %rax xchg %rax, %rdx however, dimay found agner fog's instruction tables , xchg 3 micro-op instruction 2 cycle latency on sandy bridge, ivy bridge, broadwell, haswell , skylake. 3 whole micro-ops , 2 cycles of latency! 3 micro-ops throws off 4-1-1-1 cadence , 2 cycle latency makes worse original in best case since last 2 instructions in original might execute in parallel. now... cpu might breaking instruction micro-ops equivalent to: mov %rax, %tmp mov %rdx, %rax mov %tmp, %rdx where tmp anonymous internal register , suppose last 2 micro-ops run in parallel latency 2 cycles. given register renaming occurs on these micro-architectures, though, doesn't make sense me done way. why wouldn't register renamer
Read more

jquery - Responsive Navbar with Sub Navbar -

good day, forgive me nav vocabulary not best. if question confusing apologize. i'm working on navigation bar needs centered on page @ 768px , above. items in nav open (or perhaps toggle) subnav lives directly below. these nav should appear centered on page. i have been able work through responsive portion of nav bar, having main items align vertically , sub nav menu of each item roll out below, , gave them indent separation. working well. however, issue not responsive side, behavior @ width greater 768px. happens toggling menu's sub navigation pushes other main items down page below sub nav. here's code: $(document).ready(function () { //stick in fixed 100% height behind navbar don't wrap $('#slide-nav.navbar-inverse').after($('<div class="inverse" id="navbar-height-col"></div>')); $('#slide-nav.navbar-default').after($('<div id="navbar-height-col"></d
Read more