go - http.Server Serve method hangs when calling Shutdown immediately -


i have issue go's http.server, i'm embedding in struct supposed control server startup , shutdown. struct looks this:

type httplisten struct {     consumers []pipeline.consumer     cfg       httplistenconfig     srv       *http.server     logger    log.logger     wg        *sync.waitgroup     mu        sync.mutex     state     state }

the issue in test code, call struct's start() method (which in turn runs serve() method on http.server), check few vars, , call stop(), whitch shutdown()s server , waits http.server exit (return err serve() method).

now, reason, serve() method seems hang on waitgroup.wait(), when try shutdown server after starting. when add short pause (tried 100ms), or when running tests race detector, works fine.

not sure if matters, there no incoming requests between calling serve() , shutdown().

edit: link playground minimal example. if comment out time.sleep call, program hangs.

here relevant code 2 methods:

func (h *httplisten) start() error {      h.logger.log("msg", "starting httplisten input")      addr := h.cfg.listenaddr     ln, err := net.listen("tcp", addr)     if err != nil {         h.logger.log("msg", "failed create listener on tcp/"+addr+": "+err.error())         h.setstate(statefailed)         return err     }      h.wg.add(1)     go func() {          defer h.wg.done()         err := h.srv.serve(ln)         h.logger.log("msg", "http server stopped: "+err.error())      }()      h.setstate(statestarted)     h.logger.log("msg", "httplisten input started")      return nil  }

stop method:

func (h *httplisten) stop() error {      h.logger.log("msg", "stopping httplisten input")      ctx, cancel := context.withtimeout(context.background(), time.second*10)     defer cancel()      if err := h.srv.shutdown(ctx); err != nil {         h.logger.log("msg", "http server shutdown deadline expired")     }      h.wg.wait()      h.setstate(statestopped)     h.logger.log("msg", "httplisten input stopped")      return nil }

log output:

kwz@cyclone ~/s/stblogd> go test -v ./pkg/pipeline/input/ -run testhttplisten_startstop === run   testhttplisten_startstop msg="starting httplisten input" msg="httplisten input started" msg="stopping httplisten input" ... hangs indefinitely

log output when running tests race detector:

kwz@cyclone ~/s/stblogd> go test -race -v ./pkg/pipeline/input/ -run testhttplisten_startstop === run   testhttplisten_startstop msg="starting httplisten input" msg="httplisten input started" msg="stopping httplisten input" msg="http server stopped: http: server closed" msg="httplisten input stopped" --- pass: testhttplisten_startstop (0.00s) pass ok      stblogd/pkg/pipeline/input      1.007s

i'm tempted slap short delay on test , call day, know why behaves this.

this known issue, see thread:

https://github.com/golang/go/issues/20239

hopefully fix sounds adding short delay in test simplest solution - doesn't come in real world use because won't trigger shutdown after starting.


Comments

Post a Comment

Popular posts from this blog

Is there a better way to structure post methods in Class Based Views -

i'm using class based views in django , never specify url in ajax calls , omit action parameter in form because know these requests go through post method of class based view. notice view - profile page make many requests depending on user updating on page - post method become convoluted , if/else mess example: def post(self, request, *args, **kwargs): # handle user changing available date if request.post.get('availabledate') != none: self.updateavailabledate(request) return jsonresponse({'result':'success'}) if request.post.get('newprojectname') != none: creative_user = creativeuserprofile.objects.get(id = request.user.id) project = project.create_project(creative_user, request.post['newprojectname']) project.save() return jsonresponse({'projectid': project.id }) if request.post.get('projectimage') != none , request.files['file']: proj...
Read more

performance - Why is XCHG reg, reg a 3 micro-op instruction on modern Intel architectures? -

i'm doing micro-optimization on performance critical part of code , came across sequence of instructions (in at&t syntax): add %rax, %rbx mov %rdx, %rax mov %rbx, %rdx i thought had use case xchg allow me shave instruction , write: add %rbx, %rax xchg %rax, %rdx however, dimay found agner fog's instruction tables , xchg 3 micro-op instruction 2 cycle latency on sandy bridge, ivy bridge, broadwell, haswell , skylake. 3 whole micro-ops , 2 cycles of latency! 3 micro-ops throws off 4-1-1-1 cadence , 2 cycle latency makes worse original in best case since last 2 instructions in original might execute in parallel. now... cpu might breaking instruction micro-ops equivalent to: mov %rax, %tmp mov %rdx, %rax mov %tmp, %rdx where tmp anonymous internal register , suppose last 2 micro-ops run in parallel latency 2 cycles. given register renaming occurs on these micro-architectures, though, doesn't make sense me done way. why wouldn't register renamer ...
Read more

c# - Asp.net web api : redirect unauthorized requst to forbidden page -

im trying redirect unauthorized request forbidden page instead i'm getting forbidden page in response body , how can fix ? here's startup class : app.createperowincontext(storecontext.create); app.createperowincontext<applicationusermanager>(applicationusermanager.create); app.createperowincontext<applicationsigninmanager>(applicationsigninmanager.create); app.usecookieauthentication(new cookieauthenticationoptions { authenticationtype = defaultauthenticationtypes.applicationcookie, expiretimespan = timespan.fromdays(30), }); app.useexternalsignincookie(defaultauthenticationtypes.externalcookie); app.usetwofactorsignincookie(defaultauthenticationtypes.twofactorcookie, timespan.fromminutes(5)); app.usetwofactorrememberbrowsercookie(defaultauthenticationtypes.twofactorrememberbrowsercookie); the method im trying reach : [httpget] [authorize(roles = "admin")] public string getcurrentusername() { return userman...
Read more