php - Downloading phar with nodejs. Which encoding should be used? -


i'm trying download phar (php archive) program in node.js. after testing, i've discovered files not same when downloaded browser , node.js.

i've tried few things:
"binary" encoding
"utf8" encoding
none of theses works.

do know encoding should use download phar?
code:

exports.download = function(urlstr, dest, cb) { // urlstr url link of phar, dest destination file, , cb callback.  var options = {      headers: {          "user-agent": "psm (pocketmine server manager, https://psm.mcpe.fun) user requester"      }  }  var data = "";  var url = new url(urlstr);  options.hostname = url.hostname;  options.path = url.pathname;  var request = http.get(options, function(response) {      // check if response success      if (response.statuscode == 302 || response.statuscode == 301) {          exports.download(response.headers["location"], dest, cb);          return;      }      response.on("data", function(chunk) {          data += chunk.tostring("binary");      })      response.on('end', function() {          fs.writefilesync(dest, data, "binary");          cb();      });  }).on('error', function(err) { // handle errors      fs.unlink(dest); // delete file async. (but don't check result)      if (cb) cb(err.message);  });  };

phar used (valid): https://psm.mcpe.fun/download/psmcore/1.1.phar

i noticed few issues in original code:

  • the main issue binary data being implicitly converted utf-8 string, not preserve content. keep data in buffer form or pipe response disk using streams instead of buffering entire response in memory first.

  • when using asynchronous callbacks in node, convention pass actual error object first argument instead of string. many times these objects provide more information either not contained in message itself, or not parseable error message (e.g. stack trace, libuv error code, contextual information such http uris, file paths, hostnames, etc.).

  • no 200 status code being checked before saving response disk. end saving error html pages (e.g. 400, 404, etc.) disk instead of you're expecting. should check content-type header you're expecting further ensure response think is.

an example first 2 items fixed is:

var res; function onerror(err) {   if (res) {     res.resume(); // ensure response drained     res = null;   }   if (cb) {     fs.unlink(dest, function() {});     cb(err);     cb = null;   } } http.get(options, function(response) {   // check if response success   if (response.statuscode === 302 || response.statuscode === 301) {     exports.download(response.headers["location"], dest, cb);     res.resume(); // ensure response drained     return;   }   res = response;   var out = fs.createwritestream(dest);   out.on('error', onerror);   response.pipe(out).on('close', function() {     if (cb) {       cb();       cb = null;     }   }); }).on('error', onerror);

Comments

Post a Comment

Popular posts from this blog

What is happening when Matlab is starting a "parallel pool"? -

running parallel cpu processes in matlab starts command parpool() according documentation , function: [creates] special job on pool of workers, , [connects] matlab client parallel pool. this function takes bit of time execute, on order of 30 seconds. in other multi-cpu paradigms openmp, parallel execution seems totally transparent -- i've never noticed behavior analogous matlab (granted i'm not experienced parallel programming). so, happening between time parpool() called , when finishes executing? takes long? parallel computing toolbox enables run matlab code in parallel using several different paradigms (e.g. jobs , tasks, parfor , spmd , parfeval , batch processing), , run either locally (parallelised across cores in local machine) or remotely (parallelised across machines in cluster - either 1 own, or 1 in cloud). in of these cases, code run on matlab workers , copies of matlab without interactive desktop. if you're intending run on remo...
Read more

angular - DownloadURL return null in below code -

when change file updated in firebase storage when try downloadurl show null. filechange(event: any) { const imagefolder: string = this.employee.id; const filelist: filelist = event.target.files; const file: file = filelist[0]; const storageref = firebase.storage().ref().child(`${imagefolder}/profile.jpg`).put(file); console.log(storageref.snapshot.downloadurl); } the put() asynchronous. if want url after file uploaded have this: firebase.storage().ref().child(`${imagefolder}/profile.jpg`).put(file).then((snapshot) => { storageref = snapshot.downloadurl: console.log(snapshot.downloadurl); });
Read more

php - Cannot override Laravel Spark authentication with own implementation -

during login process of laravel spark need request token of remote api. api stores exact same users , passwords laravel spark application. therefore need username , non hashed password of user during authentication process. i thought overriding authenticated method solution problem. in routes/web.php override post /login endpoint , pointing endpoint own logincontroller: <?php namespace app\http\controllers\auth; use illuminate\support\facades\log; use illuminate\http\request; use laravel\spark\http\controllers\auth\logincontroller sparklogincontroller; class logincontroller extends sparklogincontroller { /** * create new login controller instance. * * @return void */ public function __construct() { parent::__construct(); } /** * handle successful authentication attempt. * * @param request $request * @param \illuminate\contracts\auth\authenticatable $user * @return response */ public fu...
Read more