swift - ios memory leak using closure callbacks -


i have service class keeps array of subservices role send service events using 2 closure callbacks.

the service initializes subservice objects 2 closures take weak reference service in order avoid retain cycle.

public class t4fservice {     lazy var t4fsubservices: [t4fsubservice?] = self.populatesubservices()     let callbackonserviceready:  (_ isready: bool) -> ()     let callbackonbleevent: (_ broadcastdict:  notificationdict) -> ()      init?(id: t4fserviceid,       callbackonserviceready: @escaping (_ isready: bool) -> (),       callbackonbleevent: @escaping characteristiccallback){      self.callbackonserviceready = callbackonserviceready     self.callbackonbleevent = callbackonbleevent     }  func populatesubservices() -> [t4fsubservice?]  {     switch self.t4fserviceid {     case .compassserviceid:         return [t4fsubservice( t4fbleperipheraltype: .two4all, t4fcharacteristicuuidsarray: [t4fbleuuid.imumagnetometercharacteristicuuid],                                callbackonsubserviceready: { [weak self] in self!.onsubserviceready }(),                                callbackonbleevent:  { [weak self] in  self!.onbleevent}())]  func onsubserviceready(_ isready: bool) {     ...     } public func onbleevent(broadcastdict: notificationdict) {     ...     } }  class t4fsubservice{     let callbackonsubserviceready:  (_ isready: bool) -> ()     let callbackonbleevent: (_ broadcastdict:  notificationdict) -> ()      init?(t4fbleperipheraltype: t4fbleperipheraltype,       callbackonsubserviceready: @escaping (_ isready: bool) -> (),       callbackonbleevent: @escaping (_ broadcastdict:  notificationdict) -> ()){             self.callbackonsubserviceready = callbackonsubserviceready     self.callbackonbleevent = callbackonbleevent     } }

but memory graph on xcode showing retain cycle both service , subservice memory leaked!!

enter image description here

moreover looking @ graph can seen indicates instances of service , subservices captured closures strong of course cause reference cycle. surprising because pass weak reference of service closures. seems not true me xcode showing me.

is there i'm doing wrong?

ps: if change closure passed subservice initializer way memory leaks disappear. can explain it?

callbackonsubserviceready: { [weak self] in self?.onsubserviceready($0) }, callbackonbleevent:  { [weak self]  in self?.onbleevent(broadcastdict: $0)}

in closure call expression:

{ [weak self] in self!.onsubserviceready }()

the compiled code generates closure not have strong reference self.

then, closure invoked (), closure evaluates self!.onsubserviceready.

as know method reference , returns method closure. (let's call method-closure.)

and in swift, method-closures have implicit strong references self, irrelevant if self weak reference or not. expression self!.onsubserviceready (or self.onsubserviceready, when self non-optional) returns same method-closure, has strong reference self.

once invoked, [weak self] not affect evaluated result. so, when not make strong reference closure itself, [weak self] has no effect make self optional.

on other hand, closure expression:

{ [weak self] in self?.onsubserviceready($0) }

it closure , not invoking closure there. so, new closure generated, has weak reference self, , closure (which not method-closure!) passed initializer , held in instance property.

you should better create new weak-self closure, rather using method-closure, if want avoid leaks caused closures.


Comments

Post a Comment

Popular posts from this blog

Is there a better way to structure post methods in Class Based Views -

i'm using class based views in django , never specify url in ajax calls , omit action parameter in form because know these requests go through post method of class based view. notice view - profile page make many requests depending on user updating on page - post method become convoluted , if/else mess example: def post(self, request, *args, **kwargs): # handle user changing available date if request.post.get('availabledate') != none: self.updateavailabledate(request) return jsonresponse({'result':'success'}) if request.post.get('newprojectname') != none: creative_user = creativeuserprofile.objects.get(id = request.user.id) project = project.create_project(creative_user, request.post['newprojectname']) project.save() return jsonresponse({'projectid': project.id }) if request.post.get('projectimage') != none , request.files['file']: proj...
Read more

performance - Why is XCHG reg, reg a 3 micro-op instruction on modern Intel architectures? -

i'm doing micro-optimization on performance critical part of code , came across sequence of instructions (in at&t syntax): add %rax, %rbx mov %rdx, %rax mov %rbx, %rdx i thought had use case xchg allow me shave instruction , write: add %rbx, %rax xchg %rax, %rdx however, dimay found agner fog's instruction tables , xchg 3 micro-op instruction 2 cycle latency on sandy bridge, ivy bridge, broadwell, haswell , skylake. 3 whole micro-ops , 2 cycles of latency! 3 micro-ops throws off 4-1-1-1 cadence , 2 cycle latency makes worse original in best case since last 2 instructions in original might execute in parallel. now... cpu might breaking instruction micro-ops equivalent to: mov %rax, %tmp mov %rdx, %rax mov %tmp, %rdx where tmp anonymous internal register , suppose last 2 micro-ops run in parallel latency 2 cycles. given register renaming occurs on these micro-architectures, though, doesn't make sense me done way. why wouldn't register renamer ...
Read more

c# - Asp.net web api : redirect unauthorized requst to forbidden page -

im trying redirect unauthorized request forbidden page instead i'm getting forbidden page in response body , how can fix ? here's startup class : app.createperowincontext(storecontext.create); app.createperowincontext<applicationusermanager>(applicationusermanager.create); app.createperowincontext<applicationsigninmanager>(applicationsigninmanager.create); app.usecookieauthentication(new cookieauthenticationoptions { authenticationtype = defaultauthenticationtypes.applicationcookie, expiretimespan = timespan.fromdays(30), }); app.useexternalsignincookie(defaultauthenticationtypes.externalcookie); app.usetwofactorsignincookie(defaultauthenticationtypes.twofactorcookie, timespan.fromminutes(5)); app.usetwofactorrememberbrowsercookie(defaultauthenticationtypes.twofactorrememberbrowsercookie); the method im trying reach : [httpget] [authorize(roles = "admin")] public string getcurrentusername() { return userman...
Read more