c++ - EXC_BAD_ACCESS in unordered_map -


the code simple trie implementation in c++14. when executing add("name") function following error pops-up: exc_bad_access (code=1, address=0x20))

follows below debugging images:

enter image description here

enter image description here

follows code below:

struct trienode {   string value;   unordered_map<char, trienode *> children = {}; };  class trie {  public:   trienode *root = new trienode;    trienode *find(string query);    int countpartialfind(string query);    void add(string value);   private:   void add(string value, trienode *node);    trienode *createnewnode(string &value, int counter, unordered_map<char, trienode *> &children);    void add(string value, int counter, trienode *node);    trienode *findnode(char query, unordered_map<char, trienode *> &children); };  trienode *trie::find(string value) {   trienode *tmpnode = root;   (int counter = 0; counter < value.length(); counter++) {     tmpnode = findnode(value[counter], tmpnode->children);     if (tmpnode == null) {       return null;     }   }    return tmpnode; }  int trie::countpartialfind(string query) {   trienode *matchnode = find(query);   if (matchnode == null) {     return 0;   }    return matchnode->children.size(); }  void trie::add(string value, int counter, trienode *node) {   (; counter < value.length(); counter++) {     node = findnode(value[counter], node->children);     if (node == null) {       node = createnewnode(value, counter, node->children);;     }   } }  trienode *trie::findnode(char query, unordered_map<char, trienode *> &children) {   unordered_map<char, trienode *>::const_iterator search = children.find(query);   if (search == children.end()) {     return null;   }   return search->second; }  trienode *trie::createnewnode(string &value, int counter, unordered_map<char, trienode *> &children) {   trienode *newnode = new trienode;   newnode->value = value.substr(0, counter + 1);   char tmp = value[counter];   children[tmp] = newnode;   return newnode; }  void trie::add(string value) {   if (value.length() == 0) { return; }   int counter = 0;    trienode *tmpnode = findnode(value[counter], root->children);    if (tmpnode == null) {     tmpnode = createnewnode(value, counter, root->children);   }    add(value, ++counter, tmpnode); }

the issue should trivial can't catch it. helping, there other optimizations or code design done please let me know.

in 3 parameter trie::add function, when call createnewnode, node known null. 3rd parameter, node->children, dereferences null pointer, resulting in undefined behavior and, in case, crash.

if call stack @ values of local variables can see this.


Comments

Post a Comment

Popular posts from this blog

Is there a better way to structure post methods in Class Based Views -

i'm using class based views in django , never specify url in ajax calls , omit action parameter in form because know these requests go through post method of class based view. notice view - profile page make many requests depending on user updating on page - post method become convoluted , if/else mess example: def post(self, request, *args, **kwargs): # handle user changing available date if request.post.get('availabledate') != none: self.updateavailabledate(request) return jsonresponse({'result':'success'}) if request.post.get('newprojectname') != none: creative_user = creativeuserprofile.objects.get(id = request.user.id) project = project.create_project(creative_user, request.post['newprojectname']) project.save() return jsonresponse({'projectid': project.id }) if request.post.get('projectimage') != none , request.files['file']: proj
Read more

performance - Why is XCHG reg, reg a 3 micro-op instruction on modern Intel architectures? -

i'm doing micro-optimization on performance critical part of code , came across sequence of instructions (in at&t syntax): add %rax, %rbx mov %rdx, %rax mov %rbx, %rdx i thought had use case xchg allow me shave instruction , write: add %rbx, %rax xchg %rax, %rdx however, dimay found agner fog's instruction tables , xchg 3 micro-op instruction 2 cycle latency on sandy bridge, ivy bridge, broadwell, haswell , skylake. 3 whole micro-ops , 2 cycles of latency! 3 micro-ops throws off 4-1-1-1 cadence , 2 cycle latency makes worse original in best case since last 2 instructions in original might execute in parallel. now... cpu might breaking instruction micro-ops equivalent to: mov %rax, %tmp mov %rdx, %rax mov %tmp, %rdx where tmp anonymous internal register , suppose last 2 micro-ops run in parallel latency 2 cycles. given register renaming occurs on these micro-architectures, though, doesn't make sense me done way. why wouldn't register renamer
Read more

jquery - Responsive Navbar with Sub Navbar -

good day, forgive me nav vocabulary not best. if question confusing apologize. i'm working on navigation bar needs centered on page @ 768px , above. items in nav open (or perhaps toggle) subnav lives directly below. these nav should appear centered on page. i have been able work through responsive portion of nav bar, having main items align vertically , sub nav menu of each item roll out below, , gave them indent separation. working well. however, issue not responsive side, behavior @ width greater 768px. happens toggling menu's sub navigation pushes other main items down page below sub nav. here's code: $(document).ready(function () { //stick in fixed 100% height behind navbar don't wrap $('#slide-nav.navbar-inverse').after($('<div class="inverse" id="navbar-height-col"></div>')); $('#slide-nav.navbar-default').after($('<div id="navbar-height-col"></d
Read more