c# - Testing viewmodel constructor arguments with Moq -


i have basic crud application written in asp.net core, example controller action looking so:

public iactionresult sheet(guid characterid) {     var character = _repository.getcharacter(characterid);     // omit validation brevity     return view("sheet", new viewmodel(character, true, true)); }

and example unit test:

[fact] public void testsheet() {     // arrange stuff , mock setup     // act     var result = _controller.sheet(characterid) viewresult;      // assert     assert.notnull(result);      // assert viewmodel constructor called x arguments }

other research seems suggest having mock of object, not appropriate scenario. have constructor viewmodel set couple of getter properties, seem delving realm of testing viewmodel opposed controller. controller should not care viewmodel values passed it, , in opinion neither should test - test testing controller behaves properly, , should test passing correct values. couple of getter properties achieve seems conceptually wrong.

the action tightly coupled creation of view model , can inverted 

public interface iviewmodelfactory {     t createnew<t>(params object[] args) t : viewmodelbase; }  public class viewmodelfactory : iviewmodelfactory {     public t createnew<t>(params object[] args) t : viewmodelbase {         return (t)activator.createinstance(typeof(t), args);     } }  public class viewmodelbase { }

so not responsibility of controller create/initialize view models. explicit dependency injected controller , used create view models. 

public iactionresult sheet(guid characterid) {     var character = _repository.getcharacter(characterid);     // omit validation brevity     return view("sheet", _viewmodelfactory.createnew<viewmodel>(character, true, true)); }

and desired behavior can asserted when exercised in unit tests

[fact] public void testsheet() {     // arrange stuff , mock setup     var factory = new mock<iviewmodelfactory>();     factory.setup(_ => _.createnew<viewmodel>(it.isany<object[]>()))            .returns((object[] args) =>                new viewmodel((character)args[0], (bool)args[1], (bool)args[2])            );            // act     var result = _controller.sheet(characterid) viewresult;      // assert     assert.notnull(result);      // assert viewmodel constructor called x arguments     factory.verify(_ => _.createnew<viewmodel>(it.isany<character>(), true, true), times.atleastonce()); }

Comments

Post a Comment

Popular posts from this blog

Is there a better way to structure post methods in Class Based Views -

i'm using class based views in django , never specify url in ajax calls , omit action parameter in form because know these requests go through post method of class based view. notice view - profile page make many requests depending on user updating on page - post method become convoluted , if/else mess example: def post(self, request, *args, **kwargs): # handle user changing available date if request.post.get('availabledate') != none: self.updateavailabledate(request) return jsonresponse({'result':'success'}) if request.post.get('newprojectname') != none: creative_user = creativeuserprofile.objects.get(id = request.user.id) project = project.create_project(creative_user, request.post['newprojectname']) project.save() return jsonresponse({'projectid': project.id }) if request.post.get('projectimage') != none , request.files['file']: proj...
Read more

performance - Why is XCHG reg, reg a 3 micro-op instruction on modern Intel architectures? -

i'm doing micro-optimization on performance critical part of code , came across sequence of instructions (in at&t syntax): add %rax, %rbx mov %rdx, %rax mov %rbx, %rdx i thought had use case xchg allow me shave instruction , write: add %rbx, %rax xchg %rax, %rdx however, dimay found agner fog's instruction tables , xchg 3 micro-op instruction 2 cycle latency on sandy bridge, ivy bridge, broadwell, haswell , skylake. 3 whole micro-ops , 2 cycles of latency! 3 micro-ops throws off 4-1-1-1 cadence , 2 cycle latency makes worse original in best case since last 2 instructions in original might execute in parallel. now... cpu might breaking instruction micro-ops equivalent to: mov %rax, %tmp mov %rdx, %rax mov %tmp, %rdx where tmp anonymous internal register , suppose last 2 micro-ops run in parallel latency 2 cycles. given register renaming occurs on these micro-architectures, though, doesn't make sense me done way. why wouldn't register renamer ...
Read more

c# - Asp.net web api : redirect unauthorized requst to forbidden page -

im trying redirect unauthorized request forbidden page instead i'm getting forbidden page in response body , how can fix ? here's startup class : app.createperowincontext(storecontext.create); app.createperowincontext<applicationusermanager>(applicationusermanager.create); app.createperowincontext<applicationsigninmanager>(applicationsigninmanager.create); app.usecookieauthentication(new cookieauthenticationoptions { authenticationtype = defaultauthenticationtypes.applicationcookie, expiretimespan = timespan.fromdays(30), }); app.useexternalsignincookie(defaultauthenticationtypes.externalcookie); app.usetwofactorsignincookie(defaultauthenticationtypes.twofactorcookie, timespan.fromminutes(5)); app.usetwofactorrememberbrowsercookie(defaultauthenticationtypes.twofactorrememberbrowsercookie); the method im trying reach : [httpget] [authorize(roles = "admin")] public string getcurrentusername() { return userman...
Read more